Ahmad-w2-react-assignment#21
Open
AhmadSaadeddin1987 wants to merge 9 commits intoHackYourAssignment:mainfrom
Open
Ahmad-w2-react-assignment#21AhmadSaadeddin1987 wants to merge 9 commits intoHackYourAssignment:mainfrom
AhmadSaadeddin1987 wants to merge 9 commits intoHackYourAssignment:mainfrom
Conversation
Author
|
@sycons |
sycons
requested changes
Jan 11, 2026
sycons
left a comment
sycons
left a comment
There was a problem hiding this comment.
Following were implemented:
- App connects to endpoints in the API to fetch data for categories and products ✅
- Filter the products in the API and not in the frontend ✅
- App displays loading when waiting for request to complete fetching data ✅
- App shows an error message if the request failed ✅
- Clicking on product card goes to a detail page ✅
- Detail page fetches data from an endpoint ✅
- Deploy app somewhere (like netlify) and add link to PR ✅
Requested improvements:
- Remove
fake-datadirectory - Apply styling suggestions from week 1 to allow for gap between product cards
- The category list disappears when the products are loading or there is an error when fetching products. Please update so categories list is still visible.
sycons
requested changes
Jan 11, 2026
sycons
left a comment
sycons
left a comment
There was a problem hiding this comment.
Can you have separate loading and error messages for the categories and products?
See comment for more info.
sycons
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ecommerece22.netlify.app/