DMYTRO_DORONIN-w3-React#26
Open
Dmytro-Doronin wants to merge 4 commits intoHackYourAssignment:mainfrom
Open
Conversation
Author
robvk
reviewed
Jan 15, 2026
robvk
left a comment
robvk
left a comment
There was a problem hiding this comment.
No real issues with the code, nice work. I do think you need to be more careful with branches and what is pushed to a PR. This is a skill that is very important as when working in a team PR management becomes something you need to do all the time. So when you get some time (after the project) try to fix this PR so that there is no .idea folder and no prep-exercises in it.
There was a problem hiding this comment.
Don't forget to add .idea to the .gitignore. These are personal files so shouldn't be in PRs.
| @@ -0,0 +1,27 @@ | |||
| export const baseUrl = "https://fakestoreapi.com"; | |||
|
|
|||
| export type ApiError = | |||
| export const fetchFavouriteProducts = async ( | ||
| ids: number[], | ||
| ): Promise<ProductsType[]> => { | ||
| return Promise.all( |
| return ( | ||
| <div className={styles.wrapper}> | ||
| <img className={styles.img} src={image} alt={title} /> | ||
| <h3>{replaceFake(productData?.title)}</h3> |
There was a problem hiding this comment.
We didn't need the replaceFake anymore. Could have removed that dead code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.