-
Notifications
You must be signed in to change notification settings - Fork 19
Yana P. #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Yana P. #18
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,20 @@ | ||
| # Write your code here | ||
| echo "Creating project..." | ||
| mkdir project | ||
| cd project && git init | ||
| mkdir -p resources src/database src/profile && touch README.md settings.conf "resources/family picture.jpg" resources/icon.png resources/logo.png src/program.java | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Details matter. The folder created is named |
||
| git add . && git commit -m "initial commit" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works well 👍 Just a note: you can run thenm using |
||
| sleep 3 | ||
| echo "Setup project..." | ||
| echo "Welcome to my project" > README.md | ||
| rmdir src/profile | ||
| rm "resources/family picture.jpg" | ||
| git add . && git commit -m "Add info to README.md" | ||
| sleep 3 | ||
| ls -la Resources | ||
|
||
| echo "Setup javascript..." | ||
| mv src/program.java src/program.js | ||
| echo 'console.log("JavaScript works!");' > src/program.js | ||
| node src/program.js | ||
| git add . && git commit -m "Change program.java to program.js" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice descriptive commit message. |
||
| ls -la ~ | ||
| echo "All done!" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| <paste here your github username> | ||
| YanaP1312 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually it is a good practice to include
#!/bin/bashor#!/usr/bin/env bashline at the beginning of a shell script file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mo92othman for taking the time to review my work. I got a bit confused about the folder name casing, since the structure in the assignment used lowercase, while step 9 referred to an uppercase version. I’ve now made everything consistent and also added #!/bin/bash at the top as you suggested.
I’ve pushed the updated changes to GitHub, so the pull request now reflects the corrected version.
I also updated my GitHub page, and everything works properly now, including the GitHub Streak section.
Thank you again for your attention and guidance.