generated from HackYourFuture/core-assignment-week-4
-
Notifications
You must be signed in to change notification settings - Fork 18
Dagim H. #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Unlock7
wants to merge
5
commits into
HackYourAssignment:main
Choose a base branch
from
Unlock7:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dagim H. #17
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c975ad9
feat: implement core finance tracking logic reporting
e40724b
Update data.js
Unlock7 4feeffa
update: correctionOnWeek-4
Unlock7 9ecf21d
Merge branch 'main' of https://github.com/Dagim02/c55-core-week-4
Unlock7 f53fd3b
Update app.js
Unlock7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "tabWidth": 2 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,39 @@ | ||
| // This is the entrypoint for your application. | ||
| // node app.js | ||
| const chalk = require('chalk'); | ||
| const transactions = require('./data'); | ||
|
|
||
| const { | ||
| getTotalIncome, | ||
| getTotalExpenses, | ||
| getBalance, | ||
| getLargestExpense, | ||
| printAllTransactions, | ||
| } = require('./finance'); | ||
|
|
||
| // Header | ||
| console.log(chalk.bold('\n💰 PERSONAL FINANCE TRACKER 💰')); | ||
|
|
||
| // All transactions | ||
| console.log('\nAll Transactions:'); | ||
| printAllTransactions(); | ||
|
|
||
| // Summary header | ||
| console.log(chalk.bold('\n📊 FINANCIAL SUMMARY 📊')); | ||
|
|
||
| const income = getTotalIncome(); | ||
| const expenses = getTotalExpenses(); | ||
| const balance = getBalance(); | ||
|
|
||
| console.log(`Total Income: ${chalk.green('€' + income)}`); | ||
| console.log(`Total Expenses: ${chalk.red('€' + expenses)}`); | ||
|
|
||
| // Balance color logic | ||
| const balanceColor = balance >= 0 ? chalk.cyan : chalk.red; | ||
| console.log(`Current Balance: ${balanceColor('€' + balance)}`); | ||
|
|
||
| // largest expenses and total | ||
| const largest = getLargestExpense(); | ||
| console.log( | ||
| `\nLargerst Expenses: ${chalk.yellow(largest.description)} (${chalk.red('€' + largest.amount)})`, | ||
| ); | ||
|
|
||
| console.log(`Total Transactions: ${transactions.length}\n`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,44 @@ | ||
| // Place here the transaction data array. Use it in your application as needed. | ||
| const transactions = []; | ||
| const transactions = [ | ||
| { | ||
| id: 1, | ||
| type: 'income', | ||
| category: 'salary', | ||
| amount: 3000, | ||
| description: 'Monthly salary', | ||
| date: '2025-01-15', | ||
| }, | ||
| { | ||
| id: 2, | ||
| type: 'expense', | ||
| category: 'housing', | ||
| amount: 1200, | ||
| description: 'Rent', | ||
| date: '2025-01-16', | ||
| }, | ||
| { | ||
| id: 3, | ||
| type: 'expense', | ||
| category: 'food', | ||
| amount: 300, | ||
| description: 'Groceries', | ||
| date: '2025-01-17', | ||
| }, | ||
| { | ||
| id: 4, | ||
| type: 'income', | ||
| category: 'side-income', | ||
| amount: 500, | ||
| description: 'Freelance', | ||
| date: '2025-01-18', | ||
| }, | ||
| { | ||
| id: 5, | ||
| type: 'expense', | ||
| category: 'bills', | ||
| amount: 150, | ||
| description: 'Utilities', | ||
| date: '2025-01-19', | ||
| }, | ||
| ]; | ||
|
|
||
| module.exports = transactions; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,63 @@ | ||
| const transactions = require('./data'); | ||
|
|
||
| function addTransaction(transaction) { | ||
| // TODO: Implement this function | ||
| return [...transactions, transaction]; | ||
| } | ||
|
|
||
| function getTotalIncome() { | ||
| // TODO: Implement this function | ||
| const total = transactions.reduce( | ||
| (total, tx) => (tx.type === 'income' ? total + tx.amount : total), | ||
| 0, | ||
| ); | ||
|
|
||
| return total; | ||
| } | ||
|
|
||
| function getTotalExpenses() { | ||
| // TODO: Implement this function | ||
| const total = transactions.reduce( | ||
| (total, tx) => (tx.type === 'expense' ? total + tx.amount : total), | ||
| 0, | ||
| ); | ||
| return total; | ||
| } | ||
|
|
||
| function getBalance() { | ||
| // TODO: Implement this function | ||
| return getTotalIncome() - getTotalExpenses(); | ||
| } | ||
|
|
||
| function getTransactionsByCategory(category) { | ||
| // TODO: Implement this function | ||
| const getByCatagory = transactions.filter((tx) => tx.category === category); | ||
| return getByCatagory; | ||
| } | ||
|
|
||
| function getLargestExpense() { | ||
| // TODO: Implement this function | ||
| let largest = null; | ||
| for (const tx of transactions) { | ||
| if ( | ||
| tx.type === 'expense' && | ||
| (largest === null || tx.amount > largest.amount) | ||
| ) { | ||
| largest = tx; | ||
| } | ||
| } | ||
|
|
||
| return largest; | ||
| } | ||
|
|
||
| function printAllTransactions() { | ||
| // TODO: Implement this function | ||
| } | ||
| transactions.forEach((tx, index) => { | ||
| console.log( | ||
| `${index + 1}. [${tx.type.toUpperCase()}] ${tx.description} - €${tx.amount} (${tx.category})`, | ||
| ); | ||
| }); | ||
| } | ||
|
|
||
| module.exports = { | ||
| addTransaction, | ||
| getTotalIncome, | ||
| getTotalExpenses, | ||
| getBalance, | ||
| getTransactionsByCategory, | ||
| getLargestExpense, | ||
| printAllTransactions, | ||
| }; | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "name": "c55-core-week-4", | ||
| "version": "1.0.0", | ||
| "description": "The week 4 assignment for the HackYourFuture Core program can be found at the following link: https://hub.hackyourfuture.nl/core-program-week-4-assignment", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/Dagim02/c55-core-week-4.git" | ||
| }, | ||
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC", | ||
| "type": "commonjs", | ||
| "bugs": { | ||
| "url": "https://github.com/Dagim02/c55-core-week-4/issues" | ||
| }, | ||
| "homepage": "https://github.com/Dagim02/c55-core-week-4#readme", | ||
| "dependencies": { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm missing prettier...Format entire codebase with Prettier before submission |
||
| "chalk": "^4.1.2" | ||
| }, | ||
| "devDependencies": { | ||
| "prettier": "^3.8.1" | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works but it is a bit confusing... why do you first declare
let largest = { amount: 0, description: 'None' };
and in the loop you overwrite largest and have it point to tx;? What do we need { amount: 0, description: 'None' };
for? If you overwrite it anyway, largest can also be 1, or null or false.
Defining largest = { amount: 0, description: 'None' }; makes me expect that aftr the function largest will be { amount: 1200, description: 'rent' }.
Either define largest as null (like Shadi did) or even better, keep largest but make sure that largest.amount and largest description point to the greatest expense after running the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback. I will take the correction regarding the object initialization and format the entire codebase with Prettier. I will resubmit it as soon as possible.