generated from HackYourFuture/core-assignment-week-6
-
Notifications
You must be signed in to change notification settings - Fork 18
Pavel T #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pavel-tisner
wants to merge
1
commit into
HackYourAssignment:main
Choose a base branch
from
pavel-tisner:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pavel T #12
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ | |
| "score": 75, | ||
| "pass": true, | ||
| "passingScore": 50 | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| # Core program week 6 assignment | ||
|
|
||
| The week 6 assignment for the HackYourFuture Core program can be found at the following link: https://hub.hackyourfuture.nl/core-program-week-6-assignment | ||
|
|
||
| ## Implementation Instructions | ||
| - Implement the requirements in the `reading-list-manager` folder. | ||
| - Use the existing file structure. | ||
| - You are allowed to create additional files if needed. | ||
|
|
||
| - Implement the requirements in the `reading-list-manager` folder. | ||
| - Use the existing file structure. | ||
| - You are allowed to create additional files if needed. |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "es5", | ||
| "printWidth": 80 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,28 @@ | ||
| // This is the entrypoint for your application. | ||
| // node app.js | ||
| import { | ||
| loadBooks, | ||
| addBook, | ||
| getReadBooks, | ||
| getBooksByGenre, | ||
| markAsRead, | ||
| printAllBooks, | ||
| printSummary, | ||
| } from './readingList.js'; | ||
|
|
||
| // TODO: Implement the main application logic here | ||
| // 1. Load books on startup | ||
| // 2. Display all books | ||
| // 3. Show summary statistics | ||
| // 4. Add example of filtering by genre or read/unread status | ||
| // 5. Add example of marking a book as read | ||
|
|
||
| console.log('📚 MY READING LIST 📚\n'); | ||
|
|
||
| // Your implementation here | ||
| function app() { | ||
| console.log(loadBooks()); | ||
| console.log( | ||
| addBook({ | ||
| id: 8, | ||
| title: 'The Alchemist', | ||
| author: 'Paulo Coelho', | ||
| genre: 'Fiction', | ||
| read: false, | ||
| }) | ||
| ); | ||
| console.log(printAllBooks()); | ||
| console.log(getReadBooks()); | ||
| console.log(getBooksByGenre('Self-Help')); | ||
| console.log(markAsRead(3)); | ||
| console.log(printSummary()); | ||
| } | ||
| app(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,58 @@ | ||
| [] | ||
| [ | ||
| { | ||
| "id": 1, | ||
| "title": "1984", | ||
| "author": "George Orwell", | ||
| "genre": "Fiction", | ||
| "read": false | ||
| }, | ||
| { | ||
| "id": 2, | ||
| "title": "To Kill a Mockingbird", | ||
| "author": "Harper Lee", | ||
| "genre": "Fiction", | ||
| "read": true | ||
| }, | ||
| { | ||
| "id": 3, | ||
| "title": "Sapiens", | ||
| "author": "Yuval Noah Harari", | ||
| "genre": "Non-Fiction", | ||
| "read": true | ||
| }, | ||
| { | ||
| "id": 4, | ||
| "title": "The Great Gatsby", | ||
| "author": "F. Scott Fitzgerald", | ||
| "genre": "Fiction", | ||
| "read": true | ||
| }, | ||
| { | ||
| "id": 5, | ||
| "title": "Dune", | ||
| "author": "Frank Herbert", | ||
| "genre": "Sci-Fi", | ||
| "read": false | ||
| }, | ||
| { | ||
| "id": 6, | ||
| "title": "Atomic Habits", | ||
| "author": "James Clear", | ||
| "genre": "Self-Help", | ||
| "read": true | ||
| }, | ||
| { | ||
| "id": 7, | ||
| "title": "The Hitchhiker's Guide to the Galaxy", | ||
| "author": "Douglas Adams", | ||
| "genre": "Sci-Fi", | ||
| "read": false | ||
| }, | ||
| { | ||
| "id": 8, | ||
| "title": "The Alchemist", | ||
| "author": "Paulo Coelho", | ||
| "genre": "Fiction", | ||
| "read": false | ||
| } | ||
| ] |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "name": "c55-core-week-6", | ||
| "version": "1.0.0", | ||
| "description": "The week 6 assignment for the HackYourFuture Core program can be found at the following link: https://hub.hackyourfuture.nl/core-program-week-6-assignment", | ||
| "main": "app.js", | ||
| "type": "module", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "format": "prettier --write .", | ||
| "start": "node app.js" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/pavel-tisner/c55-core-week-6.git" | ||
| }, | ||
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC", | ||
| "bugs": { | ||
| "url": "https://github.com/pavel-tisner/c55-core-week-6/issues" | ||
| }, | ||
| "homepage": "https://github.com/pavel-tisner/c55-core-week-6#readme", | ||
| "dependencies": { | ||
| "chalk": "^4.1.2" | ||
| }, | ||
| "devDependencies": { | ||
| "prettier": "^3.8.1" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
printAllBooks() andprintSummary()already print to theconsole, so wrapping them inconsole.log(). Do you think we can call them directly withoutconsole.log()like: