Skip to content

Jawad A.#10

Open
jivvyjams wants to merge 2 commits intoHackYourAssignment:mainfrom
jivvyjams:main
Open

Jawad A.#10
jivvyjams wants to merge 2 commits intoHackYourAssignment:mainfrom
jivvyjams:main

Conversation

@jivvyjams
Copy link

No description provided.

@github-actions
Copy link

📝 HackYourFuture auto grade

Assignment Score: 76 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details
Vitest unit test results:

✅ post.sh: Script exists
❌ post.sh: Create user John Doe
✅ patch.sh: Script exists
❌ patch.sh: Correct the email address
✅ get.sh: Script exists
❌ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
❌ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
✅ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 13
Total failed: 4
Killed

@JQnetherlands JQnetherlands self-requested a review March 12, 2026 10:59
@JQnetherlands JQnetherlands self-assigned this Mar 12, 2026
curl -X POST http://localhost:3000/users \
-H "application/json; charset=UTF-8" \
-d
'{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look near this point to fix your code, please review my feedback

Copy link

@JQnetherlands JQnetherlands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Let’s start with the good news, You implemented the task 2 in a very organised way and following the documentation of URLSearchParams, I like a lot that you create an instance with the keyword new, that show you understand how to use it as it shows as well when you use the append method, Your code for the task is well organised and it is very easy to follow and understand.

Unfortunately , your code for the task 1 doesnt work yet, you are very near thought, I paste my log terminal to help you to find the bug, keep the good work you are almost there! I copy your curl raw to my terminal and run it with bash but either way it doesn’t work, if you have any question you can reach me out on slack:

➜ task-1 curl -X POST http://localhost:3000/users
-H "application/json; charset=UTF-8"
-d
'{
"name": "John Doe",
"email": "[email protected]",
"passowrd": "secret123"
"role": "user",
"active": true,
"department": "Engineering"
}'
curl: option -d: requires parameter
curl: try 'curl --help' or 'curl --manual' for more information
zsh: command not found: {\n "name": "John Doe",\n "email": "[email protected]",\n "passowrd": "secret123"\n "role": "user",\n "active": true,\n "department": "Engineering"\n}
➜ task-1 ./post.sh
zsh: permission denied: ./post.sh
➜ task-1 chmod +x post.sh
➜ task-1 ./post.sh
curl: option -d: requires parameter
curl: try 'curl --help' or 'curl --manual' for more information
./post.sh: line 13: {
"name": "John Doe",
"email": "[email protected]",
"passowrd": "secret123"
"role": "user",
"active": true,
"department": "Engineering"
}: command not found
➜ task-1

@JQnetherlands JQnetherlands added Review in progress Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants