Yusup R.

[Yusuprozimemet]

No description provided.

[github-actions]

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details

Vitest unit test results:

✅ post.sh: Script exists
✅ post.sh: Create user John Doe
✅ patch.sh: Script exists
✅ patch.sh: Correct the email address
✅ get.sh: Script exists
✅ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
✅ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
✅ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 17
Total failed: 0
Killed

[durw4rd]

Good job

[durw4rd]

This works because curl uses GET by default. However, I'd consider adding -X GET to make the method explicit and consistent with your other bash scripts.

[durw4rd]

Nit: I believe the users.json file was supposed to remain in the same state as at the beginning of the project. It's not the focus of the exercise, and it's not an issue either, but it's good to be cautious when committing changes to 'database' files like this one.

[durw4rd]

Good use of the URLSearchParams object constructor for the fixed params 👍