Hannah N

[hannahwn]

Networks and API

[github-actions]

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details

Vitest unit test results:

✅ post.sh: Script exists
✅ post.sh: Create user John Doe
✅ patch.sh: Script exists
✅ patch.sh: Correct the email address
✅ get.sh: Script exists
✅ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
✅ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
✅ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 17
Total failed: 0
Killed

[JQnetherlands]

See my main comment for the trail “"

[JQnetherlands]

Hello Hannah,

First of all, Congratulation your code passed all the requirements, your code is clean and well organised and it accomplishes all the goals. It is easy to understand and follow de logic.

The only thing I encountered is the following, I try your curls request by coping them and directly submit them in the terminal , not only you can try them with $ bash “file.sh”, you can use them in the terminal directly. I did that what with some of your curls you have an ending “\”, please be mindful to only use it where you need them, in this case in the post curl but it is not needed in the others (update, path, delete).

What happens when you use a command with a not needed “\”? , The terminal keep waiting for other command, that can create confusion , it is in on purpose? or the developer forgot a part of the command? because you should only use “\” if other command follow it in the same prompt. That is the only suggestion to write more clear code.

Other thing that you did very well was to put offset = 0, limit = 10 as their default value but did you know that is not strictly necessary? . Because if you read the API of the novel prizes documentation, you find out that the API gives those values as default even if you don’t provide for them.

If you already knew this but then decided to provide a default value for offset and limit, that is good to make it explicit in the code.

But if you did not know about this and then you thought it was needed, then please think in the future what is really needed and what is not, so you can make more wise choices in the future and career. Again you did overall really well , be proud of yourself.