Skip to content

Hamed R.#19

Open
HamedRazizadeh-hub wants to merge 1 commit intoHackYourAssignment:mainfrom
HamedRazizadeh-hub:main
Open

Hamed R.#19
HamedRazizadeh-hub wants to merge 1 commit intoHackYourAssignment:mainfrom
HamedRazizadeh-hub:main

Conversation

@HamedRazizadeh-hub
Copy link

No description provided.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link

📝 HackYourFuture auto grade

Assignment Score: 71 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details
TypeError: Cannot destructure property 'name' of 'req.body' as it is undefined.
    at file:///home/runner/work/c55-core-week-9/c55-core-week-9/assignment/task-1/server/server.js:53:11
    at Layer.handleRequest (/home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/router/lib/layer.js:152:17)
    at next (/home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/router/lib/route.js:157:13)
    at Route.dispatch (/home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/router/lib/route.js:117:3)
    at handle (/home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/router/index.js:435:11)
    at Layer.handleRequest (/home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/router/lib/layer.js:152:17)
    at /home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/router/index.js:295:15
    at processParams (/home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/router/index.js:582:12)
    at next (/home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/router/index.js:291:5)
    at read (/home/runner/work/c55-core-week-9/c55-core-week-9/assignment/node_modules/body-parser/lib/read.js:53:5)
Vitest unit test results:

✅ post.sh: Script exists
❌ post.sh: Create user John Doe
✅ patch.sh: Script exists
❌ patch.sh: Correct the email address
✅ get.sh: Script exists
❌ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
❌ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
❌ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 12
Total failed: 5
Killed

Copy link

@remarcmij remarcmij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HamedRazizadeh-hub, it all looks good. There is an issue though with your Git setup that causes an incompatibility with the auto-grading test. I will send you a message in slack how to fix this, also to avoid future issues.

@@ -0,0 +1 @@
curl -X DELETE http://localhost:3000/users/11 No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is customary to start bash scripts with a "shebang" as the very first line:

#!/bin/bash

@remarcmij remarcmij added the Reviewed This assignment has been reivewed by a mentor and a feedback has been provided label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants