Diana

[dianadenwik]

No description provided.

[github-actions]

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details

Vitest unit test results:

✅ post.sh: Script exists
✅ post.sh: Create user John Doe
✅ patch.sh: Script exists
✅ patch.sh: Correct the email address
✅ get.sh: Script exists
✅ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
✅ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
✅ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 17
Total failed: 0
Killed

[JalalHabeeb]

Nice done.
I have only 2 comments:

1. Adding echo at the end of the bash command forces the cursor in the terminal to move to a new line, which makes the terminal more readable.
2. Using params.append is good in this case. But in general, params.set is the better choice here — it signals intent more clearly: "this parameter has one value." .append implies you might be building a list of values for the same key (like category=phy&category=che), which isn't what's happening.
   The difference matters when you might add the same key twice:

• .append("key", "a") then .append("key", "b") → key=a&key=b (two values)
• .set("key", "a") then .set("key", "b") → key=b (second overwrites first)