Skip to content

Pavel T#9

Open
pavel-tisner wants to merge 1 commit intoHackYourAssignment:mainfrom
pavel-tisner:main
Open

Pavel T#9
pavel-tisner wants to merge 1 commit intoHackYourAssignment:mainfrom
pavel-tisner:main

Conversation

@pavel-tisner
Copy link

No description provided.

@github-actions
Copy link

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details
Vitest unit test results:

✅ post.sh: Script exists
✅ post.sh: Create user John Doe
✅ patch.sh: Script exists
✅ patch.sh: Correct the email address
✅ get.sh: Script exists
✅ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
✅ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
✅ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 17
Total failed: 0
Killed

@remarcmij remarcmij self-assigned this Mar 11, 2026
Copy link

@remarcmij remarcmij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pavel-tisner, looks good! Just a minor comment on an unneeded request header.


curl http://localhost:3000/users/11 \
--request DELETE \
--header 'Content-Type: application/json' \ No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Content-Type header specifies how the request body should be interpreted. However, the GET and DELETE methods do not have a request body. So, you can just ignore this request header. The API server just ignores it.


curl http://localhost:3000/users/11 \
--request GET \
--header 'Content-Type: application/json' \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content-Type not needed. No request body.

@remarcmij remarcmij added the Reviewed This assignment has been reivewed by a mentor and a feedback has been provided label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants