This repository has been archived by the owner on May 22, 2020. It is now read-only.
Window refresh 2 named exports #986
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openfin-github-bot
bot
added
the
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
| @@ -21,7 +21,7 @@ let minimist = require('minimist'); | |||
| // local modules | |||
| let Application = require('./src/browser/api/application.js').Application; | |||
| let System = require('./src/browser/api/system.js').System; | |||
| import { Window } from './src/browser/api/window'; | |||
| import { create } from './src/browser/api/window'; | |||
There was a problem hiding this comment.
Nitpick: Considering this file is as huge as it is, I think it's more descriptive to have the Window.create call vs just a plain create call. Can be hard to tell exactly what's being created.
There was a problem hiding this comment.
Trying not to import the whole file here, it helps with circular dependencies on the typescript conversion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Switch to named exports from window.js
Checklist
npm testpassesRelease Notes
Notes: n/a internal