fix: token suspicion adjustment #477
Open
+16
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, before batching and other optimizations, these were the speeds we considered unreasonable but new paradigms, backends and breakthroughs have made these numbers increasingly inaccurate or irrelevant.
While I do think there has to be some sort of longer term solution (such as the one addressing the problem detailed in #463), there have been virtually only false positives, and the few true positives boiled down to innocent misconfigurations.
Further, it appears that certain types of worker-reported failures can artificially inflate token count, which may be its own issue.
For the time being, I am advocating that the number is increased to 100t/s for most models, as recommended by henky, and that we respond to possible abuse of this relaxation with other, more complete and sound, measures.