Abridged Fight Scene#190
Open
rayrobdod wants to merge 7 commits into
Open
Conversation
Not delete, just hide under a flag that could easily turn into a setting
This is closer to what FEGBA means by "no animations". For when you still want to be shown some indication of what's going on, but don't want to wait quite as much time to see it.
Have all mutations occur in AttackCommand and HealCommand, instead of appearing in both FightStage and AbridgedFightScene.
Collaborator
Author
|
One thing I want to do soon, but have not done yet, is detect when a full battle animation is missing assets, and if so drop down to using the abridged scene instead. That I consider this the next step should emphasize that I consider this a step towards resource modding (Or, in case of emergency, purging the battle_anims directory); the detection would allow having a class without having animations for that class. I like battle animations too, but they are hard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a less-detailed battle animation, as well as a setting to use this animation instead of the full one.
An open question is whether there are better names (or shorter ones - I think the name of one bleeds into its choices) or better choice name for these settings.