Skip to content

Properly draw progress bar when timer advances #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsj merged 1 commit into from
May 12, 2025
Merged

Properly draw progress bar when timer advances #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions Source/CountDown.spoon/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ function obj:show_message(msg, duration)
if not duration then
duration = obj.messageDuration
end
print(">>>>>>>>>>>>>>>>", duration)
hs.alert.show(msg, obj.messageAttributes, nil, duration)
end

Expand Down Expand Up @@ -379,21 +378,17 @@ function obj:bar_create_timer()
local secCount = math.ceil(60*minutes)
obj.currentIcon = obj.menuBarIconActive
obj.loopCount = 0

if mainRes.w/secCount >= minimumStep then
-- do every second
barTimer = hs.timer.doEvery(1, function()
obj:bar_updateProgress()
end)
else
-- we need few seconds to advance two pixels
local interval = 2/(mainRes.w/secCount)
barTimer = hs.timer.doEvery(interval,
function()
obj:barSetProgresspercentage(obj.barProgress)
end
)

local interval = 1

if mainRes.w/secCount < minimumStep then
interval = 2/(mainRes.w/secCount)
end
barTimer = hs.timer.doEvery(interval,
function()
obj:bar_updateProgress()
end
)
end

---- warning related functions
Expand Down