Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic POC input device support and rotary encoder implementation as an example #192

Merged
merged 38 commits into from
Jan 3, 2025

Conversation

HaoboGu
Copy link
Owner

@HaoboGu HaoboGu commented Dec 16, 2024

update: input device support will be separated to several PRs. This PR adds traits for input devices and input processors, implements those traits for rotary encoders(as an example)

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@HaoboGu
Copy link
Owner Author

HaoboGu commented Jan 3, 2025

It seems that input devices requires lots of API changes.. It's a breaking change and current API isn't good for end users. So I'll revert the API changes and keep only traits and sample rotary encoder implementations.

To support the input device well, the whole architecture of the project needs to be upgraded. I'll do it in other PRs.

@HaoboGu HaoboGu changed the title WIP: Input device Add basic POC input device support and rotary encoder implementation as an example Jan 3, 2025
@HaoboGu HaoboGu marked this pull request as ready for review January 3, 2025 08:04
Copy link

github-actions bot commented Jan 3, 2025

PR build size

  text	   data	    bss	    dec	    hex	filename
122596	    116	  41308	 164020	  280b4	rmk-nrf52840

Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +4.93Ki  [ = ]       0    .debug_str
  +0.4% +3.22Ki  [ = ]       0    .debug_info
  +1.2% +2.29Ki  [ = ]       0    .debug_loc
  +0.9% +1.02Ki  [ = ]       0    .strtab
  +0.7%    +744  [ = ]       0    .debug_ranges
  +0.4%    +420  +0.4%    +420    .text
  +0.3%    +385  [ = ]       0    .debug_line
  +1.0%    +168  [ = ]       0    .debug_aranges
  +0.3%    +128  [ = ]       0    .symtab
  +1.5%      +6  [ = ]       0    .defmt
  +0.0%      +4  +0.0%      +4    .rodata
 -11.3%      -7  [ = ]       0    [Unmapped]
  +0.5% +13.3Ki  +0.3%    +424    TOTAL

Signed-off-by: Haobo Gu <[email protected]>
Copy link

github-actions bot commented Jan 3, 2025

PR build size

  text	   data	    bss	    dec	    hex	filename
122596	    116	  41308	 164020	  280b4	rmk-nrf52840

Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +4.93Ki  [ = ]       0    .debug_str
  +0.4% +3.21Ki  [ = ]       0    .debug_info
  +1.2% +2.29Ki  [ = ]       0    .debug_loc
  +0.9% +1.02Ki  [ = ]       0    .strtab
  +0.7%    +744  [ = ]       0    .debug_ranges
  +0.4%    +420  +0.4%    +420    .text
  +0.3%    +384  [ = ]       0    .debug_line
  +1.0%    +168  [ = ]       0    .debug_aranges
  +0.3%    +128  [ = ]       0    .symtab
  +1.5%      +6  [ = ]       0    .defmt
  +0.0%      +4  +0.0%      +4    .rodata
  -9.7%      -6  [ = ]       0    [Unmapped]
  +0.5% +13.3Ki  +0.3%    +424    TOTAL

@HaoboGu HaoboGu merged commit acfd3db into main Jan 3, 2025
24 of 25 checks passed
@HaoboGu HaoboGu deleted the feat/input_device branch January 3, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant