-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic POC input device support and rotary encoder implementation as an example #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haobo Gu <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Haobo Gu <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
…coder as the example Signed-off-by: Haobo Gu <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Haobo Gu <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
It seems that input devices requires lots of API changes.. It's a breaking change and current API isn't good for end users. So I'll revert the API changes and keep only traits and sample rotary encoder implementations. To support the input device well, the whole architecture of the project needs to be upgraded. I'll do it in other PRs. |
6 tasks
Signed-off-by: Haobo Gu <[email protected]>
HaoboGu
changed the title
WIP: Input device
Add basic POC input device support and rotary encoder implementation as an example
Jan 3, 2025
PR build size
Diff
|
Signed-off-by: Haobo Gu <[email protected]>
PR build size
Diff
|
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update: input device support will be separated to several PRs. This PR adds traits for input devices and input processors, implements those traits for rotary encoders(as an example)