Skip to content
This repository was archived by the owner on Jun 1, 2024. It is now read-only.

Asynctask issue #3051 solved #3058

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Asynctask issue #3051 solved #3058

wants to merge 4 commits into from

Conversation

@hassan963
Copy link

@hassan963 hassan963 commented Aug 27, 2019 •
edited by Alexendoo
Loading

Below classes changed and inner AsyncTask classes are changed to separate static classes. Also added WeakReference<> for context and view. Added cancel() method for AsyncTask in onPause() method in Activity.

1.     me.ccrama.redditslide.Vote
2.     me.ccrama.redditslide.Activities.CommentsScreenSingle
3.     me.ccrama.redditslide.Activities.Inbox
4.     me.ccrama.redditslide.Activities.LiveThread

Separate AsyncTask classes are in Services package

1. me.ccrama.redditslide.Services.CommentScreenTask.java
2. me.ccrama.redditslide.Services.InboxTask.java
3. me.ccrama.redditslide.Services.LiveThreadTask.java

Closes #3051

Alexendoo
Alexendoo reviewed Aug 28, 2019
View reviewed changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Alexendoo Alexendoo Alexendoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misuse of AsyncTask

2 participants

@hassan963 @Alexendoo