feat: jests tests added#62
Open
RaveenDilaksha wants to merge 1 commit intoHardhat-Enterprises:devfrom
Open
Conversation
Collaborator
|
Looks good, could you just reslove the conflicts, should be able to just let npm sort it out once you've updated your branch with the dev branch. Once this is done I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit tests for helpers:
• domainHelper.test.js → date parsing, domain age, risky TLD, privacy detection,
TXT parsing, and risk score scenarios
• netHelper.test.js → mocked dns/promises and tls to verify DNS/SSL logic without real I/O
• whois.service.test.js → mocked axios + net helpers to test orchestration and error handling
Benefits:
• Improved reliability with deterministic tests and mocks
• Modular test structure mirrors code architecture for easier maintenance