site: fix pricing section horizontal overflow on mobile - #258
Merged
Merged
Conversation
Safari sizes <select> elements to their longest option and WebKit range inputs carry an intrinsic min-width, so the plan cards forced the whole page to scroll sideways on phones (founder report with screenshots). min-width:0 down the flex/grid chain (pgroup, plan, cfg, select, seat slider) and width:100% + ellipsis on the configurator selects.
Contributor
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Founder report with iPhone screenshots: the pricing section forced the whole page to scroll sideways on mobile Safari.
Cause: Safari sizes elements to their longest option text (the sandbox tier labels are long), and WebKit range inputs carry an intrinsic min-width — the plan grid could not shrink below content width. Fix: min-width: 0 down the flex/grid chain (.pgroup, .plan, .cfg, .cfg select, .seat-ctl range) and width: 100% + text-overflow: ellipsis on the configurator selects. No markup or logic changes; desktop layout unchanged.