feat: bitstream#12
Open
leia-uwu wants to merge 1 commit into
Open
Conversation
ei-pi
reviewed
Jan 23, 2026
ei-pi
reviewed
Jan 23, 2026
ei-pi
reviewed
Jan 23, 2026
ei-pi
reviewed
Jan 23, 2026
ei-pi
reviewed
Jan 23, 2026
ei-pi
reviewed
Jan 23, 2026
ei-pi
reviewed
Jan 23, 2026
ei-pi
reviewed
Jan 23, 2026
ei-pi
reviewed
Jan 23, 2026
ei-pi
left a comment
ei-pi
left a comment
There was a problem hiding this comment.
looks overall good, just a few silly typos to fix, and a test case to verify (if it fails, i think I know why)
leia-uwu
force-pushed
the
feat/bitstream
branch
2 times, most recently
from
28381fc to
3dbbfe5
Compare
leia-uwu
force-pushed
the
feat/bitstream
branch
2 times, most recently
from
aa6a699 to
bfe61de
Compare
ei-pi
reviewed
Jan 29, 2026
ei-pi
reviewed
Jan 29, 2026
ei-pi
suggested changes
Jan 29, 2026
leia-uwu
force-pushed
the
feat/bitstream
branch
3 times, most recently
from
31fe30e to
2c51af4
Compare
ei-pi
approved these changes
Jan 30, 2026
leia-uwu
force-pushed
the
feat/bitstream
branch
from
2c51af4 to
adb4c51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(also i want to eventually move the Buff class outside of it for other stuff to use)