Add geckodriver support

README.md

@@ -10,7 +10,7 @@ For browser automation and writing integration tests in Elixir.
 
 * Can run __multiple browser sessions__ simultaneously. [See example](https://github.com/HashNuke/hound/blob/master/test/multiple_browser_session_test.exs).
 
-* Supports Selenium (Firefox, Chrome), ChromeDriver and PhantomJs.
+* Supports Selenium (Firefox, Chrome), ChromeDriver, geckodriver (note: [only supports a single session for now](https://github.com/mozilla/geckodriver/issues/882)) and PhantomJs.
 
 * Supports Javascript-heavy apps. Retries a few times before reporting error.
 

lib/hound/connection_server.ex

@@ -9,6 +9,8 @@ defmodule Hound.ConnectionServer do
         {9515, nil, "chrome"}
       "phantomjs" ->
         {8910, nil, "phantomjs"}
+      "geckodriver" ->
+        {4444, nil, "firefox"}
       _ -> # assume selenium
         {4444, "wd/hub/", "firefox"}
     end

lib/hound/helpers/element.ex

@@ -23,18 +23,18 @@ defmodule Hound.Helpers.Element do
 
   @spec inner_html(Hound.Element.selector) :: String.t
   def inner_html(element) do
-    attribute_value(element, "innerHTML")
+    property_value(element, "innerHTML")
   end
 
 
   @spec inner_text(Hound.Element.selector) :: String.t
   def inner_text(element) do
-    attribute_value(element, "innerText")
+    property_value(element, "innerText")
   end
-  
+
   @spec outer_html(Hound.Element.selector) :: String.t
   def outer_html(element) do
-    attribute_value(element, "outerHTML")
+    property_value(element, "outerHTML")
   end
 
   @doc """
@@ -166,6 +166,24 @@ defmodule Hound.Helpers.Element do
   end
 
 
+  @doc """
+  Gets an element's property value.
+
+      element = find_element(:name, "example")
+      property_value(element, "innerHTML")
+
+  You can also pass the selector as a tuple, for the first argument
+
+      property_value({:name, "example"}, "innerHTML")
+  """
+  @spec property_value(Hound.Element.selector, String.t) :: String.t | :nil
+  def property_value(element, property_name) do
+    element = get_element(element)
+    session_id = Hound.current_session_id
+    make_req(:get, "session/#{session_id}/element/#{element}/property/#{property_name}")
+  end
+
+
   @doc """
   Checks if an element has a given class.
 

lib/hound/internal_helpers.ex

@@ -11,6 +11,7 @@ defmodule Hound.InternalHelpers do
       "focus_parent_frame"
     ],
     chrome_driver: [],
+    geckodriver: [],
     selenium: []
   ]
 

lib/hound/request_utils.ex

@@ -71,11 +71,14 @@ defmodule Hound.RequestUtils do
       {"chrome_driver", _} ->
         Hound.ResponseParsers.ChromeDriver
 
+      {"geckodriver", _} ->
+        Hound.ResponseParsers.GeckoDriver
+
       {"phantomjs", _} ->
         Hound.ResponseParsers.PhantomJs
 
       other_driver ->
-        raise "No response parser found for #{other_driver}"
+        raise "No response parser found for #{inspect other_driver}"
     end
   end
 

lib/hound/response_parser.ex

@@ -43,6 +43,9 @@ defmodule Hound.ResponseParser do
   def handle_response(_mod, "session", code, %{"sessionId" => session_id}) when code < 300 do
     {:ok, session_id}
   end
+  def handle_response(_mod, "session", code, %{"value" => %{"sessionId" => session_id}}) when code < 300 do
+    {:ok, session_id}
+  end
   def handle_response(mod, _path, _code, %{"value" => %{"message" => message} = value}) do
     if mod.warning?(message) do
       Logger.warn(message)
@@ -51,7 +54,7 @@ defmodule Hound.ResponseParser do
       mod.handle_error(value)
     end
   end
-  def handle_response(_mod, _path, _code, %{"status" => 0, "value" => value}), do: value
+  def handle_response(_mod, _path, _code, %{"value" => value}), do: value
   def handle_response(_mod, _path, code, _body) when code < 400, do: :ok
   def handle_response(_mod, _path, _code, _body), do: :error
 

lib/hound/response_parsers/geckodriver.ex

@@ -0,0 +1,9 @@
+defmodule Hound.ResponseParsers.GeckoDriver do
+  @moduledoc false
+
+  use Hound.ResponseParser
+
+  def handle_error(%{"message" => "Unable to locate element:" <> _rest}) do
+    {:error, :no_such_element}
+  end
+end