feature/handle-remaining-logic#66
Merged
Merged
Conversation
Farah315
reviewed
Oct 17, 2025
| UserDataSource.addPoints(points) | ||
| } | ||
|
|
||
| override suspend fun updateLives(lives: Int) { |
Contributor
There was a problem hiding this comment.
can u add also current heart live , or get live heart ?cuz i want it in game screen so i can make a check when i lose and remove heart
Contributor
There was a problem hiding this comment.
I know I saw it, but sorry for overthinking, my way of thinking is I'm here i wanna implement in game screen so the name i think will express it is get live heart or smth like that, so when i lose a game i easily can use update live and make sure it's updated in home screen, I think we can put the name is get live heart so we can update &get in same time
…aining-logic # Conflicts: # app/src/main/java/com/thechance/qurio/di/DataModule.kt
Farah315
reviewed
Oct 18, 2025
Comment on lines
+3
to
+4
| interface CharacterBuyView { | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Suggested change
| interface CharacterBuyView { | |
| } | |
| interface CharacterBuyView: BaseView |
Farah315
reviewed
Oct 18, 2025
Comment on lines
-51
to
+53
| super.onViewCreated(view, savedInstanceState) | ||
| println("parent") |
Contributor
There was a problem hiding this comment.
why u add println here?, for check u can use log and delete it after u sure its work
nourelhodaahmed
approved these changes
Oct 18, 2025
Farah315
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-10-18.at.6.08.21.AM.mov