Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix String::__boot when smart strings are disabled #1192

Merged

Conversation

tobil4sk
Copy link
Member

Can be verified by running this code with -D disable-unicode-strings.

function main() {
	trace(StringTools.fastCodeAt(String.fromCharCode(128), 0));
	trace(StringTools.fastCodeAt(String.fromCharCode(255), 0));
}

The current (incorrect) output is:

src/Main.hx:2: 194
src/Main.hx:3: 195

With the patch, the output is correct:

src/Main.hx:2: 128
src/Main.hx:3: 255

@Simn Simn merged commit dd050c0 into HaxeFoundation:master Feb 11, 2025
120 checks passed
@skial skial mentioned this pull request Feb 11, 2025
1 task
@tobil4sk tobil4sk deleted the fix/string-boot-no-smart-strings branch February 11, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants