Skip to content

Conversation

@veitbjarsch
Copy link

@veitbjarsch veitbjarsch commented Feb 17, 2025

I got the following error:

image

The android docs state the following:
image

This PR addresses the error and ensures that the library properly handles cases where no matching provider is found. I'm not a Java developer, so I appreciate your patience and feedback!

@HarelM
Copy link
Collaborator

HarelM commented Feb 17, 2025

I believe this is the case when a device doesn't have a GPS (some tables for example do not have a GPS I believe).
But in this case I don't think there's a valid use case for an app that uses this plugin, right?

@veitbjarsch
Copy link
Author

The error happend on the OnePlus 7 using Android 11. I think this phone should have a GPS.

@HarelM
Copy link
Collaborator

HarelM commented Feb 18, 2025

I don't see a reason the provider should be null in this case...
While the app might not crash it will also not work properly as well.
I think a better solution should be provided...

@veitbjarsch
Copy link
Author

The information the play console provides, indicates that the application crashed. I'm not an Java developer on android. So I don't really know why the provider could be null in this case, but as it looks like is. And also the documentation states, that the provider can return null.

@HarelM
Copy link
Collaborator

HarelM commented Feb 20, 2025

As I said, the app won't crash but also won't work as well, so I'm not sure what's the gain here.
Did you try using this fork in production and see that the crashes are reduced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants