test(packaging): cover native manifest parse refusals - #417
Closed
harshitethic wants to merge 1 commit into
Closed
Conversation
|
👋 Hi @harshitethic — thanks for the contribution! To keep starter issues available You already have #415 open, so this one is being closed automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add focused regression coverage for the four native-overlay manifest refusals tracked in #408:
artifactswith a non-array shape;Each case builds a real one-module Cython overlay, mutates only
hflow-native-overlay.json, calls the publicapply_cython_overlaypath, pins the exact refusal, and verifies the source remains in place with no native artifact or installed manifest published.The canonical-JSON case keeps the parsed payload semantically identical and changes serialization only. The duplicate-field case edits raw bytes because a Python mapping cannot represent duplicate keys.
No production behavior or error text is changed.
Closes #408.
Validation
The new tests use the same real-overlay path as the existing packaging refusal coverage and therefore require the repository's documented system C compiler. GitHub Actions is the authoritative full-suite validation for this branch.
AI assistance disclosure: AI assistance was used to inspect the issue and existing test patterns, prepare the focused tests, and review the resulting change.