feat-add-verbose-tags-to-cli - #49
Conversation
|
👋 Hi @klnsv — thank you so much for your first contribution to HFlow! A maintainer will review your pull request as soon as possible. In the meantime:
💡 Tip: one open pull request per contributor at a time. Issues with an assignee are taken; everything else is fair game. We are excited to have you here and appreciate your help making the project better! 🙌 |
kstonekuan
left a comment
There was a problem hiding this comment.
Thank you @klnsv, and welcome! This lands #28 exactly as specified: the global -v/--verbose flag, logging.basicConfig before dispatch in main(), the stderr assertion test, and the optional cleanup of the dead logger in episode.py (confirmed it had no logger. call). Validated locally: full quality gate clean and all 304 tests pass. Nice touch saving and restoring the root logger handlers in the test so basicConfig actually takes effect under pytest without leaking state. Merging now.
Summary
Fixed the issue (#28) by adding the --verbose and -v cli arguments
Why
Validation
pytestruffChecklist
uv run ruff check --fix,uv run ruff format, anduv run ty check.