Skip to content

feat-add-verbose-tags-to-cli - #49

Merged
kstonekuan merged 1 commit into
Hebbian-Robotics:mainfrom
klnsv:klnsv/fix-issue-28
Aug 20, 2026
Merged

feat-add-verbose-tags-to-cli#49
kstonekuan merged 1 commit into
Hebbian-Robotics:mainfrom
klnsv:klnsv/fix-issue-28

Conversation

@klnsv

@klnsv klnsv commented Aug 20, 2026

Copy link
Copy Markdown

Summary

Fixed the issue (#28) by adding the --verbose and -v cli arguments

Why

Validation

  1. pytest
 uv run pytest -q
warning: Failed to parse `pyproject.toml` during settings discovery:
  TOML parse error at line 66, column 17
     |
  66 | exclude-newer = "5 days"
     |                 ^^^^^^^^
  failed to parse year in date "5 days": failed to parse "5 da" as year (a four digit integer): invalid digit, expected 0-9 but got

......................................................................s......................................... [ 36%]
................................................................................................................ [ 72%]
....................s................................s.............................                              [100%]
304 passed, 3 skipped in 32.23s
  1. ruff
 uv run ruff check --fix
uv run ruff format
uv run ty check
warning: Failed to parse `pyproject.toml` during settings discovery:
  TOML parse error at line 66, column 17
     |
  66 | exclude-newer = "5 days"
     |                 ^^^^^^^^
  failed to parse year in date "5 days": failed to parse "5 da" as year (a four digit integer): invalid digit, expected 0-9 but got

Found 3 errors (3 fixed, 0 remaining).
warning: Failed to parse `pyproject.toml` during settings discovery:
  TOML parse error at line 66, column 17
     |
  66 | exclude-newer = "5 days"
     |                 ^^^^^^^^
  failed to parse year in date "5 days": failed to parse "5 da" as year (a four digit integer): invalid digit, expected 0-9 but got

1 file reformatted, 86 files left unchanged
warning: Failed to parse `pyproject.toml` during settings discovery:
  TOML parse error at line 66, column 17
     |
  66 | exclude-newer = "5 days"
     |                 ^^^^^^^^
  failed to parse year in date "5 days": failed to parse "5 da" as year (a four digit integer): invalid digit, expected 0-9 but got

All checks passed!

Checklist

  • I added or updated outcome-focused tests for changed business logic.
  • I updated documentation for changed behavior, flags, formats, or requirements.
  • I ran uv run ruff check --fix, uv run ruff format, and uv run ty check.
  • I ran the relevant pytest suite.
  • I did not add recordings, generated media, credentials, private URLs, or runtime artifacts.
  • I preserved stored-data compatibility or documented an explicit version change.

@github-actions

Copy link
Copy Markdown

👋 Hi @klnsv — thank you so much for your first contribution to HFlow!

A maintainer will review your pull request as soon as possible. In the meantime:

💡 Tip: one open pull request per contributor at a time. Issues with an assignee are taken; everything else is fair game.

We are excited to have you here and appreciate your help making the project better! 🙌

@kstonekuan kstonekuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @klnsv, and welcome! This lands #28 exactly as specified: the global -v/--verbose flag, logging.basicConfig before dispatch in main(), the stderr assertion test, and the optional cleanup of the dead logger in episode.py (confirmed it had no logger. call). Validated locally: full quality gate clean and all 304 tests pass. Nice touch saving and restoring the root logger handlers in the test so basicConfig actually takes effect under pytest without leaking state. Merging now.

@kstonekuan
kstonekuan merged commit 46f1f9c into Hebbian-Robotics:main Aug 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants