This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 29
feat: allow custom base path #169
Open
freality
wants to merge
10
commits into
Hebilicious:main
Choose a base branch
from
freality:feat/custom-base-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add basePath to module config w/ default /api/auth * generate auth.config.mjs module file * add #auth-config alias
replace hardcoded basePath with config variable
Hebilicious
suggested changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for contributing.
This is looking great!
Looks like the tests are failing so this will need a bit more work.
Could you try to remove the ts-expect errors and add a declaration file to handle the config?
I'm seeing the same build error when run against the main branch. |
Really looking for the feature also is blocking our current work any update @Hebilicious |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Allow custom base path other than /api/auth #168
β Type of change
π Description
By allowing the user to configure a
basePath
, the user can implement their NuxtAuthHandler on any route they chose.This PR adds an optional
basePath
to the module configuration object (with default/api/auth
for backwards compatibility). It generates a#build/auth.config.mjs
with#auth-config
alias. And uses the configuration variable where needed.Docs are also updated to include the new basePath configuration.
resolves #168
π Checklist