Skip to content

ext4: small write refactor + block leak fix #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcimerman
Copy link
Contributor

Pull request includes 2 commits:

  • ext4: write: sparse/unallocated block helper fcn:

    • put handling of sparse or unallocated blocks into a helper function
    • this small refactor will help with implementing multi-block writes
    • also while at it put static in ext4_instance_get() definition, as it should be, see the prototype
  • ext4: write: fix block leak:

    • extends the helper function with allocated bool hint, based on which we can free
      the allocated block on later error paths, which previously didn't free it

I am putting this PR up earlier without waiting until I finish my multi-block read/write feature proposals, in hope that this will get merged faster as it's not a big change.

Feedback/improvements/edits are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant