ext4: small write refactor + block leak fix #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request includes 2 commits:
ext4: write: sparse/unallocated block helper fcn:
static
inext4_instance_get()
definition, as it should be, see the prototypeext4: write: fix block leak:
allocated
bool hint, based on which we can freethe allocated block on later error paths, which previously didn't free it
I am putting this PR up earlier without waiting until I finish my multi-block read/write feature proposals, in hope that this will get merged faster as it's not a big change.
Feedback/improvements/edits are welcome.