Misc simplification, May 2026 edition#221
Closed
Bisaloo wants to merge 6 commits into
Closed
Conversation
Bisaloo
commented
May 30, 2026
Bisaloo
commented
Collaborator
- Some of these might be sujective or I might be missing the reason it is a certain way, please review
- If there is a risk for conflicts with ongoing PR, let's merge the other first because this is easily rebased.
Owner
|
I'm not sure about conflicts but this is all great and not really subjective imo!! |
Bisaloo
force-pushed
the
misc-simplification-052026
branch
from
May 30, 2026 16:21
ec7b913 to
dd17b34
Compare
Artur-man
reviewed
May 30, 2026
| if (!length(v)) stop("couldn't find 'version' in 'spatialdata_attrs'") | ||
| ok <- length(v) == 1 && is.character(v) && (v <- gsub("-.*", "", v)) %in% sprintf("0.%d", seq_len(6)) | ||
| if (!ok) stop("invalid OME 'version'; expected '0.x' where x is 1-5") | ||
| if (!ok) stop("invalid OME 'version'; expected '0.x' where x is 1-6") |
Collaborator
There was a problem hiding this comment.
What is the release schedule for OME-NGFF 0.6 btw ?
Owner
|
merged into #226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.