Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database class related and initialize beatmap local database #125

Merged
merged 32 commits into from
Aug 18, 2022

Conversation

HelloYeew
Copy link
Owner

This is the branch that I worked for a long time to ensure that everything are ready for the next phase that we will make the CRUD operation on the beatmap related.

@HelloYeew
Copy link
Owner Author

HelloYeew commented Jul 21, 2022

This PR is start to bloat now, will start clean up process and ready for review.

@HelloYeew HelloYeew marked this pull request as ready for review July 23, 2022 16:49
Copy link
Collaborator

@Game4all Game4all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, a few things to note though

@HelloYeew HelloYeew requested a review from Game4all August 17, 2022 19:45
@HelloYeew HelloYeew merged commit be5ccc9 into master Aug 18, 2022
@HelloYeew HelloYeew deleted the initial-database branch August 18, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants