Add scrollable beatmap list #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Game4all
reviewed
Apr 15, 2023
| RelativeSizeAxes = Axes.Both, | ||
| Children = new Drawable[] | ||
| { | ||
| dummyBox = new Container() |
There was a problem hiding this comment.
not sure dummyBox is right? am open to bikeshedding here, anything but "dummy" please
| @@ -24,7 +24,7 @@ public partial class BeatmapSetCard : CompositeDrawable | |||
| [Resolved] | |||
| private MaisimConfigManager gameConfig { get; set; } | |||
|
|
|||
| private readonly BeatmapSet beatmapSet; | |||
| protected internal readonly BeatmapSet BeatmapSet; | |||
There was a problem hiding this comment.
not sure about the internal accessor here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a branch that's not PR for a long time now....
This design based from an arcade game and just scroll through or click to select the song.
CleanShot.2023-03-22.at.09.44.09.mp4
There maybe a problem here...
topBoxandbottomBoxis not draw based on screen and it need to be... (Due to it cannot useAxes.BothonRelativeSizeAxes)MusicPlayerbehavior since the song selection screen is just suspended so it will still scroll to the highlight point despite not in the screen (fixed)TODO