chore: pin test VS Code version + .gitignore trailing newline#20
Conversation
Addresses review nits from #19: - Pin `version` in .vscode-test.mjs to 1.101.0 (the minimum declared in engines.vscode) instead of `stable`. Tests now run against the floor the extension claims to support, and CI is not silently affected by stable-channel VS Code updates. Verified: downloads 1.101.0 and the suite passes (2 passing, 13 pending, 0 failing). - Add the missing trailing newline to .gitignore. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Makes test execution deterministic by pinning the VS Code test runtime to the extension’s declared minimum supported VS Code version, and fixes a formatting nit in .gitignore.
Changes:
- Pin
.vscode-test.mjstest VS Code version fromstableto1.101.0(aligned withengines.vscode: ^1.101.0). - Add the missing trailing newline in
.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.vscode-test.mjs |
Pins the VS Code version used by @vscode/test-cli to ensure stable, reproducible CI runs against the minimum supported version. |
.gitignore |
Restores a trailing newline to satisfy formatting expectations and avoid diff noise. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Review — PR #20: chore: pin test VS Code version + .gitignore trailing newlineOverview: A small, clean housekeeping PR that pins the test runner to VS Code 1.101.0 (matching What's Good
SuggestionsMaintenance coupling (medium): The pinned version in // Pin to the minimum supported VS Code (matches engines.vscode in package.json).
// When bumping engines.vscode, update this version too.
version: '1.101.0',This is a nit — the existing comment is already helpful, and the linkage is clear from the PR description. SummaryStraightforward improvement with no risks. The maintenance-coupling note is purely informational — the change is correct as-is. Approve. |
Summary
Addresses the two actionable review nits from #19.
.vscode-test.mjsfromstable→1.101.0, matching the minimum declared inengines.vscode(^1.101.0). Running againststablemeans the binary silently auto-updates, so a future breaking change could cause hard-to-attribute CI failures. Pinning to the supported floor makes the test baseline deterministic and verifies the extension works on the oldest VS Code it claims to support..gitignore.Verification
npm testagainst the pinned version:The third #19 nit (double
findExampleManuscriptPath()call in the skip guard) was left as-is — it's a harmless micro-optimisation at test-startup speed and the duplication keeps each guard self-contained.🤖 Generated with Claude Code