Skip to content

chore: pin test VS Code version + .gitignore trailing newline#20

Merged
paxcalpt merged 1 commit into
mainfrom
chore/pin-test-vscode-version
May 29, 2026
Merged

chore: pin test VS Code version + .gitignore trailing newline#20
paxcalpt merged 1 commit into
mainfrom
chore/pin-test-vscode-version

Conversation

@paxcalpt
Copy link
Copy Markdown
Contributor

Summary

Addresses the two actionable review nits from #19.

  • Pin the test VS Code version in .vscode-test.mjs from stable1.101.0, matching the minimum declared in engines.vscode (^1.101.0). Running against stable means the binary silently auto-updates, so a future breaking change could cause hard-to-attribute CI failures. Pinning to the supported floor makes the test baseline deterministic and verifies the extension works on the oldest VS Code it claims to support.
  • Add the missing trailing newline to .gitignore.

Verification

npm test against the pinned version:

✔ Downloaded VS Code into .vscode-test/vscode-darwin-arm64-1.101.0
  2 passing (35ms)
  13 pending
Exit code: 0

The third #19 nit (double findExampleManuscriptPath() call in the skip guard) was left as-is — it's a harmless micro-optimisation at test-startup speed and the duplication keeps each guard self-contained.

🤖 Generated with Claude Code

Addresses review nits from #19:
- Pin `version` in .vscode-test.mjs to 1.101.0 (the minimum declared in
  engines.vscode) instead of `stable`. Tests now run against the floor the
  extension claims to support, and CI is not silently affected by
  stable-channel VS Code updates. Verified: downloads 1.101.0 and the suite
  passes (2 passing, 13 pending, 0 failing).
- Add the missing trailing newline to .gitignore.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 29, 2026 19:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes test execution deterministic by pinning the VS Code test runtime to the extension’s declared minimum supported VS Code version, and fixes a formatting nit in .gitignore.

Changes:

  • Pin .vscode-test.mjs test VS Code version from stable to 1.101.0 (aligned with engines.vscode: ^1.101.0).
  • Add the missing trailing newline in .gitignore.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
.vscode-test.mjs Pins the VS Code version used by @vscode/test-cli to ensure stable, reproducible CI runs against the minimum supported version.
.gitignore Restores a trailing newline to satisfy formatting expectations and avoid diff noise.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude
Copy link
Copy Markdown

claude Bot commented May 29, 2026

Code Review — PR #20: chore: pin test VS Code version + .gitignore trailing newline

Overview: A small, clean housekeeping PR that pins the test runner to VS Code 1.101.0 (matching engines.vscode in package.json) and fixes a missing trailing newline in .gitignore. Low risk and well-reasoned.


What's Good

  • Deterministic CI baseline. Pinning to the floor version is the right call. Running against stable means a silent VS Code update can break CI in a way that's hard to attribute to any specific code change.
  • Correct floor choice. 1.101.0 directly matches the ^1.101.0 constraint in engines.vscode, so the pinned version is exactly the oldest VS Code the extension claims to support.
  • The comment is useful. It explains why the version is pinned, which prevents a future contributor from casually "upgrading" it back to stable.

Suggestions

Maintenance coupling (medium): The pinned version in .vscode-test.mjs now needs to be kept in sync with engines.vscode in package.json manually. If the minimum supported VS Code version is ever bumped, two files must change. Consider adding a brief reminder in the comment:

// Pin to the minimum supported VS Code (matches engines.vscode in package.json).
// When bumping engines.vscode, update this version too.
version: '1.101.0',

This is a nit — the existing comment is already helpful, and the linkage is clear from the PR description.


Summary

Straightforward improvement with no risks. The maintenance-coupling note is purely informational — the change is correct as-is. Approve.

@paxcalpt paxcalpt merged commit e7451d4 into main May 29, 2026
3 checks passed
@paxcalpt paxcalpt deleted the chore/pin-test-vscode-version branch May 29, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants