Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/decoder #8

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Feature/decoder #8

merged 2 commits into from
Oct 17, 2020

Conversation

inmoonlight
Copy link
Member

Pull Request

레파지토리에 기여해주셔서 감사드립니다.

해당 PR을 제출하기 전에 아래 사항이 완료되었는지 확인 부탁드립니다:

  • 작성한 코드가 어떤 에러나 경고없이 빌드가 되었나요?
  • 충분한 테스트를 수행하셨나요?

1. 해당 PR은 어떤 내용인가요?

  • decoder 구현
  • config 를 빌더 형태로 변경하면서 발생한 버그 해결

2. PR과 관련된 이슈가 있나요?

#1

@inmoonlight inmoonlight requested review from ssaru and seopbo October 11, 2020 02:57
ssaru
ssaru approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@ssaru ssaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inmoonlight

엄청 깔끔해진 느낌입니다. 🙌
LGTM 입니다.

Base automatically changed from feature/encoder to master October 17, 2020 07:30
@inmoonlight
Copy link
Member Author

check fail 은 #9 에서 수정하겠습니다!

@inmoonlight inmoonlight merged commit f6f644a into master Oct 17, 2020
@inmoonlight inmoonlight deleted the feature/decoder branch October 17, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssaru ssaru ssaru approved these changes

@seopbo seopbo Awaiting requested review from seopbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inmoonlight @ssaru