Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supress warning in skill_attack when MAGIC_REFLECTION_TYPE is 0. #2175

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Supress warning in skill_attack when MAGIC_REFLECTION_TYPE is 0. #2175

merged 1 commit into from
Aug 24, 2018

Conversation

bWolfie
Copy link
Contributor

@bWolfie bWolfie commented Aug 10, 2018

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

If MAGIC_REFLECTION_TYPE is set to 0 in src/config, a warning will appear in skill_attack. This suppresses it.

Affected Branches:

  • master
  • stable

Issues addressed:

#1920

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@bWolfie bWolfie changed the base branch from stable to master August 10, 2018 13:40
@MishimaHaruna MishimaHaruna added this to the Release v2018.08.26 milestone Aug 24, 2018
@MishimaHaruna MishimaHaruna merged commit dbfe239 into HerculesWS:master Aug 24, 2018
@Helianthella Helianthella mentioned this pull request Aug 27, 2018
Closed
5 tasks
@bWolfie bWolfie deleted the skill_attack_warning branch August 27, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4144 4144 4144 approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2018.08.26
Development

Successfully merging this pull request may close these issues.
4 participants
@bWolfie @HerculesWSAPI @4144 @MishimaHaruna