-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
551 tooltip component #615
base: main
Are you sure you want to change the base?
Conversation
| "right-end"; | ||
}; | ||
|
||
export const CustomTip: React.FC<TooltipProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
One small suggestion: the component name could be improved for better clarity and alignment with its purpose. Perhaps calling it MuiTooltipWrapper
would make its functionality more evident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion! I completely agree that a more descriptive name like MuiTooltipWrapper would better convey the component's purpose. It’s a great idea, and I’ll make the update accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @abdou6666,
I have updated the component name to MuiTooltipWrapper as suggested. Please review the changes and let me know if there’s anything else you’d like me to adjust.
Thank you!
export const CustomTip: React.FC<TooltipProps> = ({ | ||
children, | ||
text, | ||
position = "top", | ||
}) => { | ||
return ( | ||
<MuiTooltip title={text} placement={position} arrow> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const CustomTip: React.FC<TooltipProps> = ({ | |
children, | |
text, | |
position = "top", | |
}) => { | |
return ( | |
<MuiTooltip title={text} placement={position} arrow> | |
export const InfoTip: React.FC<MuiTooltipProps> = ({ | |
children, | |
position = "top", | |
...props | |
}) => { | |
return ( | |
<MuiTooltip {...props} placement={position} arrow> | |
I suggest re-using the original MUI props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the MuiTooltipWrapper component to re-use MuiTooltipProps directly, allowing full flexibility with all MUI props.
Motivation
This update introduces localized strings for English (
en
) and French (fr
) to enhance user accessibility and usability in a multilingual environment. Additionally, a newCustomTip
component has been created to provide enhanced tooltip functionality across the application. These changes improve user experience by standardizing tooltips and enabling better visual guidance in the app. TheCustomTip
component has been integrated into key files likeDiagrams.tsx
andHeader.tsx
.Fixes #551
Type of Change:
Checklist:
Changes Made:
Localization Files:
English (
translation.json
)"profile": "Profile"
"add_new_flow": "Add new flow"
"toggle_menu": "Toggle menu"
French (
translation.json
)"profile": "Profil"
"add_new_flow": "Ajouter un nouveau flux"
"toggle_menu": "Basculer le menu"
New Component:
CustomTip
Tooltip
."top"
.Integration:
CustomTip
in:frontend/src/components/visual-editor/v2/Diagrams.tsx
frontend/src/layout/Header.tsx
Screenshorts