Skip to content

Feat: refactor stdout envelopes#793

Closed
abdou6666 wants to merge 2 commits intomainfrom
feat/refactor-stdout-envelopes
Closed

Feat: refactor stdout envelopes#793
abdou6666 wants to merge 2 commits intomainfrom
feat/refactor-stdout-envelopes

Conversation

@abdou6666
Copy link
Copy Markdown
Contributor

@abdou6666 abdou6666 commented Feb 20, 2025

Motivation

WIP

This PR aims to simplify the logic of creating StdOutgoingEnvelopes using combination of Factory and Builder design pattern.

I opened this PR mainly to get feedback about the API DX wise so any feedback is welcome!

Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abdou6666
Copy link
Copy Markdown
Contributor Author

closed in favor #853

@abdou6666 abdou6666 closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant