Feat/use handlebars for mailing #828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marrouchi
requested changes
Mar 14, 2025
api/src/logger/logger.service.ts
Outdated
Comment on lines
55
to
64
| if ( | ||
| arg && | ||
| type === 'error' && | ||
| typeof arg === 'object' && | ||
| 'stack' in arg | ||
| ) { | ||
| super[type](arg.stack); | ||
| } else { | ||
| super[type](arg); | ||
| } |
There was a problem hiding this comment.
Let's move this to another PR
There was a problem hiding this comment.
its already in different PR #825
The reason it's appearing in this PR is i checkout from that branch should be removed we merge!
|
|
||
| module.exports = { | ||
| async up(services: MigrationServices) { | ||
| await updateContextVarsHandleBarsSyntaxe2(MigrationAction.UP, services); |
There was a problem hiding this comment.
Suggested change
| await updateContextVarsHandleBarsSyntaxe2(MigrationAction.UP, services); | |
| await updateContextVarsHandleBarsSyntax(MigrationAction.UP, services); |
In addition we need to have support for translations
abdou6666
force-pushed
the
feat/use-handlebars-for-mailing
branch
from
3a3366b to
bd4c18e
Compare
marrouchi
changed the base branch from
main
to
feat/handlebars-context-var-token-replacement
marrouchi
changed the base branch from
feat/handlebars-context-var-token-replacement
to
feat/enahnce-error-logs
|
Closed in favor of the rebased one : #836 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #827
Type of change:
Please delete options that are not relevant.
Checklist: