fix: thread referrer through OIDC state so signup records acquisition… - #2939
Closed
jelveh wants to merge 4 commits into
Closed
fix: thread referrer through OIDC state so signup records acquisition…#2939jelveh wants to merge 4 commits into
jelveh wants to merge 4 commits into
Conversation
… origin OIDC signups never had the referrer field set because the callback request from the IdP doesn't carry the frontend's JSON body. Fix by passing referrer as a query param to the OIDC start endpoint, embedding it in the signed state JWT, and forwarding it to createUserFromOIDC. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ProgrammerIn-wonderland
left a comment
ProgrammerIn-wonderland
left a comment
Collaborator
There was a problem hiding this comment.
Code looks sane, need to test
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OIDC signups never had the referrer field set because the callback request from the IdP doesn't carry the frontend's JSON body. Fix by passing referrer as a query param to the OIDC start endpoint, embedding it in the signed state JWT, and forwarding it to createUserFromOIDC.