Skip to content

🧹 PUT-1568: Rename GUI helper files to camelCase - #3641

Merged
jfcastro92 merged 2 commits into
mainfrom
juancastro/put-1568-rename-srcguisrchelpers-files-to-camelcase
Aug 26, 2026
Merged

🧹 PUT-1568: Rename GUI helper files to camelCase#3641
jfcastro92 merged 2 commits into
mainfrom
juancastro/put-1568-rename-srcguisrchelpers-files-to-camelcase

Conversation

@jfcastro92

Copy link
Copy Markdown
Collaborator

src/gui/src/helpers was mostly snake_case, disagreeing with itself and with the camelCase file convention in AGENTS.md. Rename the 45 offenders with git mv and repoint every import specifier at the new paths.

Files only — exported symbols are unchanged. applyItemAddedToContainers.js still exports apply_item_added_to_containers and no call site is edited beyond its import line; those identifiers cross module boundaries and some hang off window, so renaming them is a separate, riskier change.

src/gui/src/helpers was mostly snake_case, disagreeing with itself and
with the camelCase file convention in AGENTS.md. Rename the 45 offenders
with git mv and repoint every import specifier at the new paths.

Files only — exported symbols are unchanged. applyItemAddedToContainers.js
still exports apply_item_added_to_containers and no call site is edited
beyond its import line; those identifiers cross module boundaries and some
hang off window, so renaming them is a separate, riskier change.
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for puter.js SDK

Status Category Percentage Covered / Total
🔵 Lines 62.07%
⬆️ +0.05%
3930 / 6331
🔵 Statements 60.89%
⬆️ +0.03%
4140 / 6799
🔵 Functions 62.28%
🟰 ±0%
758 / 1217
🔵 Branches 54.82%
🟰 ±0%
2539 / 4631
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/puter-js/src/modules/UI.js 6.69%
🟰 ±0%
6.46%
🟰 ±0%
2.97%
🟰 ±0%
7.18%
🟰 ±0%
256-260, 282-424, 481-544, 563, 566, 570-575, 587-590, 596, 599, 603, 608-611, 617-641, 646-659, 666-682, 688-711, 716-718, 723-724, 729-731, 736-737, 743-828, 833-835, 840-845, 848-871, 882-891, 918-1619, 1635-1636, 1648-2166, 2183-2338, 2365-2414, 2418-2428, 2450-2719, 2734-2884
Generated in workflow #193 for commit 07e73ef by the Vitest Coverage Report Action

@jfcastro92 jfcastro92 changed the title refactor: rename GUI helper files to camelCase :sweep: PUT-1568: Rename GUI helper files to camelCase Aug 25, 2026
@jfcastro92 jfcastro92 changed the title :sweep: PUT-1568: Rename GUI helper files to camelCase 🧹 PUT-1568: Rename GUI helper files to camelCase Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 93.65%
🟰 ±0%
24533 / 26194
🔵 Statements 91.93%
🟰 ±0%
26498 / 28821
🔵 Functions 89.85%
🟰 ±0%
4280 / 4763
🔵 Branches 80.55%
🟰 ±0%
17895 / 22214
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/backend/drivers/apps/AppDriver.js 86.12%
🟰 ±0%
79.07%
🟰 ±0%
100%
🟰 ±0%
90.39%
🟰 ±0%
109, 237-239, 377, 541, 690-694, 729, 775-777, 784, 786-787, 819, 821, 829, 843-844, 888, 896, 909, 927, 982, 1015-1034, 1076, 1095, 1100, 1116, 1130-1134, 1139, 1165, 1167, 1180-1186, 1191, 1220, 1221, 1222, 1223, 1224, 1246-1254, 1258, 1270, 1271, 1272, 1367-1373, 1376-1382, 1391-1397, 1415, 1441-1445
Generated in workflow #832 for commit 07e73ef by the Vitest Coverage Report Action

@jfcastro92
jfcastro92 requested a review from Salazareo August 25, 2026 19:12

@Salazareo Salazareo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but just care that no dynamic import or anything like that breaks, maybe test on zenpacket first

@jfcastro92

jfcastro92 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Chased the dynamic-import concern. Results:

Check How Result
Dynamic imports of helper paths git grep -E "import\([^)]*helpers/" over src/ none exist
Computed/interpolated module paths grep for import(`…${…}`) in src/gui/src none
Stale path references git grep "<old_name>.js" for all 45 old basenames 0 hits
References outside JS grep *.html, *.json, src/gui/build.js, vi.mock() 0 (one prose mention of launch_app() in TESTING.md)
Case-only renames reviewed all 45 none — all snake→camel, so a stale import fails locally instead of only on Linux
Static imports resolve node src/gui/build.js builds; webpack hard-errors on unresolved imports, incl. the split chunk
Runtime boot, branch vs main signed-in desktop in Playwright, capturing console + page errors + failed requests byte-identical output on both
GUI unit tests vitest run src/gui/src 31 files / 346 tests pass — same count as main, so no renamed test dropped out of discovery

Zenpacket tests:
Screenshot 2026-08-26 at 10 00 00 AM
Screenshot 2026-08-26 at 10 00 08 AM

@jfcastro92
jfcastro92 merged commit b05ee63 into main Aug 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants