-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IRC portion of Bancho #212
Conversation
Unit testing should require a basic IRC library for testing connections |
For this implementation since the web frontend doesn't even support logging in yet we will have the IRC token be a Bancho command |
For the event system since we already support chat events that come from Bancho it might be good to support a specific IRC chat event and move to also having a generic chat event to cover both grounds. Edit: Too much work, just made generic |
Seems the correct response to an incorrect password or no password given when required is to respond with ERR_PASSWDMISMATCH however that doesn't prompt the user to re-enter a password on HexChat which seems like it would be expected behaviour. Message will need to be ammended to say what to do to get your password and let the user know to set it but it needs to be looked into if that's the only solution. Edit: Some clients prompt afterwards |
Closes #25
This is a work in progress implementation: