Channel pages default search bar to include channel#806
Open
lbmaian wants to merge 1 commit intoHolodexNet:devfrom
Open
Channel pages default search bar to include channel#806lbmaian wants to merge 1 commit intoHolodexNet:devfrom
lbmaian wants to merge 1 commit intoHolodexNet:devfrom
Conversation
lbmaian
force-pushed
the
channeldefaultsearch
branch
from
bd11567 to
b2ee12e
Compare
Contributor
Author
|
Anything blocking this from being accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching for only a channel, it goes to the channel page. However this removes the channel from the search bar, which is inconvenient when trying to search within a channel from that page.
This addresses that by adding a "default" channel item to the search bar on channel pages. This item is removed when going to a non-channel/search page, or replaced if going to another channel page.