codex: use package release asset#268453
Open
sluongng wants to merge 1 commit into
Open
Conversation
This fixes Codex startup failures when users enable the forked-zsh
shell backend from the Homebrew cask.
The current cask installs the bare codex-#{arch}-#{os}.tar.gz asset,
which only contains the Codex binary. Codex 0.137.0 also publishes a
codex-package-#{arch}-#{os}.tar.gz asset containing the package layout
that the CLI expects for bundled resources: bin/codex,
codex-package.json, codex-path/rg, and codex-resources/zsh/bin/zsh.
Use that package asset and link bin/codex as the public executable.
Keep the bundled zsh and rg private inside the package root so Codex can
discover them through its install context without exposing extra PATH
entries or replacing Homebrew's ripgrep dependency.
Author
|
I don't think CI failures are related to my change here 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the Codex cask from the bare
codex-#{arch}-#{os}.tar.gzrelease asset to
codex-package-#{arch}-#{os}.tar.gz.The bare asset only contains the Codex binary. Codex also publishes a
package asset containing the package layout used by the CLI to discover
bundled resources:
bin/codexcodex-package.jsoncodex-path/rgcodex-resources/zsh/bin/zshWithout that layout, enabling Codex's forked-zsh shell backend can fail
at startup because no packaged zsh fork is available for the install.
The package asset keeps those resources private under the Caskroom while
only linking
bin/codexas the public executable.I tested the package asset locally through a temporary cask tap and
codex doctorrecognized the install as a brew package layout withresources.