Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autobump: remove deprecated formulae #204097

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

autobump: remove deprecated formulae #204097

wants to merge 1 commit into from
+1 −13

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 13, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to #204044

@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jan 13, 2025
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Jan 13, 2025
@chenrui333 chenrui333 enabled auto-merge January 13, 2025 16:39
@SMillerDev
Copy link
Member

Are all of these no longer livecheckable? We should really have an audit for that.

@chenrui333 chenrui333 disabled auto-merge January 13, 2025 19:16
@chenrui333
Copy link
Member Author

Are all of these no longer livecheckable? We should really have an audit for that.

they are all deprecated formulae, so no need to autobump anymore.

@chenrui333 chenrui333 enabled auto-merge January 13, 2025 19:17
@SMillerDev
Copy link
Member

Deprecated can still be updated. Only if they're unmaintained, archived or not building they should be removed.

@chenrui333
Copy link
Member Author

Deprecated can still be updated. Only if they're unmaintained, archived or not building they should be removed.

yeah, exactly, they are not maintained (that is why they marked as deprecated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @SMillerDev