Fixed wildcard file path rules for drive roots #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue with wildcard file paths roots that you make for supplemental or deny policies by selecting the root of the drives such as C: or D: Previously they would look like "C:\\*" in the policy but now it's fixed by not adding the extra backward slash when drive root is selected
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
AppControl Manager/XMLOps/SignerAndHashBuilder.cs:389
- The variable 'DriveLetters' is an IEnumerable<string?>, which means it can contain null values. Add a null check to avoid potential runtime exceptions.
string wildcardPath = DriveLetters.Any(x => string.Equals(x, item[..^1], System.StringComparison.OrdinalIgnoreCase)) ? item + "*" : item + @"\" + "*";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with wildcard file paths that you make for supplemental or deny policies by selecting the root of the drives such as
C:orD:Previously they would look like
C:\\*in the policy XML file but now it's fixed by not adding the extra backward slash when drive root is selected.