Skip to content

Complete subscription support #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bastienho
Copy link
Contributor

This PR make other payments in a subscription reliable.

Explanations:

  • When vads_trans_id is sent in the request, it's also return its value in the IPN
  • But in a subscription context, on others payments, the vads_trans_id is replaced by a generated transaction ID

My approach is to populate the vads_order_id field with the same value as vads_trans_id and use it as internal transaction id. The value of this field is kept over all future payments.

In the meantime, we add a getTransactionReference() with the value of vads_subscription_id which allows to attribute new transaction to the correct subscription.

@damsfx does it make sens?

I have a doubt about the duplicate value in order_id and trans_id.

@damsfx
Copy link
Member

damsfx commented Dec 15, 2023

@bastienho Sorry for the late reply, I've got a very busy schedule.

Have you been able to test it in a real-life situation? I don't have any cases where I can test your modifications.

I have a doubt about the duplicate value in order_id and trans_id.

Mee too.

Perhaps you can add the required tests to your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants