Complete subscription support #12
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make other payments in a subscription reliable.
Explanations:
vads_trans_id
is sent in the request, it's also return its value in the IPNvads_trans_id
is replaced by a generated transaction IDMy approach is to populate the
vads_order_id
field with the same value asvads_trans_id
and use it as internal transaction id. The value of this field is kept over all future payments.In the meantime, we add a
getTransactionReference()
with the value ofvads_subscription_id
which allows to attribute new transaction to the correct subscription.@damsfx does it make sens?
I have a doubt about the duplicate value in order_id and trans_id.