LANG-1675 - Improve performance of StringUtils.join for primitives - preview #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HubertWo
changed the title
|
14 files changed? It looks like you need to rebase on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces StringJoiner to StringBuilder in StringUtils.join methods.
The change is limited to methods which use primitives as input only.
More
Please find more details here:
2.[LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter apache/commons-lang#784
JMH with example results
JMH tests - StringBuilder vs StringJoiner may be found in dedicated repository:
https://github.com/HubertWo/apache-commons-lang-jmh