Remove the RC2 registry startup race - #55
Merged
Merged
Conversation
The macOS arm64 release host can start the publish test quickly enough to connect before the reference-registry subprocess binds. Treat the server's post-bind listening line as the test readiness contract and expose child failures in the test log. Constraint: The reference registry counts accepted connections against max-requests, so socket probing would consume test traffic. Rejected: Retry production package uploads | This is a test orchestration race and changing client semantics would mask startup failures. Confidence: high Scope-risk: narrow Directive: Keep the listening line emitted only after a successful bind, or update this test readiness contract atomically. Tested: cargo fmt --all -- --check; cargo test -p sgpm reference_registry; cargo test -p sgpm -- --test-threads=1; cargo clippy -p sgpm --all-targets -- -D warnings Not-tested: macOS arm64 locally; the release-host matrix will provide that evidence. Co-authored-by: OmX <omx@oh-my-codex.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
n- cargo test -p sgpm reference_registry -- --nocapturen- cargo test -p sgpm -- --test-threads=1n- cargo clippy -p sgpm --all-targets -- -D warningsnRelease context
This addresses the macOS arm64 failure in run 30186249172 without changing public language, stdlib, CLI, manifest, diagnostic, protocol, or runtime ABI behavior.