Cleanup & Proper usage of NIO #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up the files making them more readable (Slimmed down path resolutions and added method getMinecraftPath as an alternative to getWorkingPath which replaces a lot of reused calls) Moved getWorkingPath code to the field workingPath in net.hypixel.resourcepack.pack.Pack so that it is only created once instead of re-creating it every call (this was also done for the getMinecraftPath method) Fixed incorrect usage of nio Paths being converted to io files then accessed instead of using the Files interface for nio. This also includes the use of Collections.singleton when writing the file as this can be replaced with a call to getBytes(Charset)
|
It would be great if this would be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the files making them more readable
(Slimmed down path resolutions and added method getMinecraftPath as an alternative to getWorkingPath which replaces a lot of reused calls)
Moved getWorkingPath code to the field workingPath
in net.hypixel.resourcepack.pack.Pack so that it is only created once instead of re-creating it every call (this was also done for the getMinecraftPath method)
Fixed incorrect usage of nio Paths being converted to io files then accessed instead of using the Files interface for nio. This also includes the use of Collections.singleton when writing the file as this can be replaced with a call to getBytes(Charset)