-
Notifications
You must be signed in to change notification settings - Fork 17
Refactoring UserIdentity logics #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sunnywu
wants to merge
873
commits into
syw-UID2-4159-token-gen-code-renaming
Choose a base branch
from
syw-UID2-4159-token-gen-code-refactoring-UserIdentity
base: syw-UID2-4159-token-gen-code-renaming
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactoring UserIdentity logics #1097
sunnywu
wants to merge
873
commits into
syw-UID2-4159-token-gen-code-renaming
from
syw-UID2-4159-token-gen-code-refactoring-UserIdentity
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -3,6 +3,9 @@ | |||
|
|||
public class PrivacyBits { | |||
|
|||
// For historical reason this bit is set | |||
public static final int DEFAULT_PRIVACY_BIT_VALUE = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be PrivacyBits
instead?
public static final PrivacyBits DEFAULT = PrivacyBits.fromInt(1);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed all uses of int PrivacyBits
and use PrivacyBits
class instead. Added unit tests to test the class
78a70d4
to
a8f0915
Compare
…VE-2025-29087 Fixing vulnerability CVE-2025-29087
…VE-2025-29087 Fixing vulnerability CVE-2025-29087
…echLab/uid2-operator into ian-UID2-5118-ignore-sigterm-signal
clean up v0/v1 endpoints related code
…en-code-refactoring-UserIdentity
…251829738723549 [CI Pipeline] Released Patch version: 5.56.36
* Reduce the log entries in var/log/operator.log for private operator
* Add debugging message * Remove allow_environment_variable_dropping flip * [CI Pipeline] Released Snapshot version: 5.56.40-alpha-257-SNAPSHOT --------- Co-authored-by: Release Workflow <[email protected]>
…en-code-refactoring-UserIdentity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
token
variable names to adTokenInput and refreshTokenInput to make it clearer