Add "path" and "dii_type" labels to identity/map metrics#2429
Merged
Add "path" and "dii_type" labels to identity/map metrics#2429
Conversation
swibi-ttd
changed the title
cYKatherine
reviewed
Mar 12, 2026
| .summary(); | ||
| assertNotNull(phoneHashSummary); | ||
| assertEquals(1.0, phoneHashSummary.totalAmount()); | ||
|
|
Contributor
There was a problem hiding this comment.
maybe add an emailHashSummary and phoneSummary (=0) as well
Contributor
Author
There was a problem hiding this comment.
good idea - have added assertions for all 4 DII types in the tests
cYKatherine
approved these changes
Mar 12, 2026
cYKatherine
approved these changes
Mar 12, 2026
split Service metrics into separate caches
add IdentityMapV2Input record to pass back dii_type from request parsing
swibi-ttd
force-pushed
the
swi-UID2-6706-identity-map-metrics
branch
from
ce0f347 to
25e8cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathlabel to all Identity Map metrics to distinguish /v2/ and /v3/ requestsdii_typelabel (email,email_hash,phone,phone_hash) toidentity_map_inputsmetrics. Total count will now be derived viasum by (api_contact, path)uid2_operator_optout_status_optout_sizewas never initialised - split this metric into a separate cache to fixIdentityMapV2Inputwithdii_typeandinputListso we can easily pass backdii_typefrom input parsing (used in metric recording)Testing